Cache paths returned from Pooch to avoid repeated checksum in unit tests #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl-wynen
reviewed
Apr 9, 2025
src/ess/sans/data.py
Outdated
| def __contains__(self, key): | ||
| return key in self._registry.registry | ||
|
|
||
| @cache # noqa: B019 |
There was a problem hiding this comment.
Can you put a comment why it is ok to cache self in this case?
This seems to save, e.g., 0.3 seconds a whole bunch of times. Not huge but noticeable. Is it a good idea?
jl-wynen
force-pushed
the
cache-path-from-pooch
branch
from
dc438ae to
2dae5c0
Compare
|
I updated the PR to use scipp/essreduce#261. The tests should pass as is but will only benefit from caching once ESSreduce is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to save, e.g., 0.3 seconds a whole bunch of times. Not huge but noticeable. Is it a good idea?