-
Notifications
You must be signed in to change notification settings - Fork 22
docs: add developer.md #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
=======================================
Coverage 94.86% 94.86%
=======================================
Files 2 2
Lines 331 331
Branches 61 61
=======================================
Hits 314 314
Misses 10 10
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@matthewfeickert I am trying to create a 0.9.1 version and I followed your video, but https://github.com/scikit-hep/pylhe/actions/runs/11403842254/job/31731751820#step:8:46 here "Bump version" fails with Further I still need to figure out conda after pypi. |
|
@matthewfeickert @eduardo-rodrigues Can one of you help with releasing pylhe 0.9.1? |
|
It is best that @matthewfeickert helps as I have not released here so far. I tend to do my releases a different way. Can you help out @matthewfeickert? Aside - this PR isn't done, right? Maybe better have this "admin" doc under the docs directory? |
@APN-Pucky Sorry, I've been pretty distracted (feel free to poke me on email/Slack if I'm not responsive on GitHub as my notifications can become just a wall sometimes). Can you tell me where you're hitting this specifically in the release workflow? |
|
I fixed @APN-Pucky not having publishing permissions in PR #269, but I also went ahead and released
@APN-Pucky the good news is that there really isn't anything to figure out. Conda-forge automatically watches PyPI for new releases and will generate a new release PR to https://github.com/conda-forge/pylhe-feedstock for us in a few hours. We then just review it to make sure there are no dependency changes and then we can merge it and conda-forge will then do all the building and publishing automatically. |
|
I will try to create a release for v0.9.2 following the steps outlined in this PR. |
|
@matthewfeickert Unfortunately, running the dry run bump-version for 0.9.2 fails already https://github.com/scikit-hep/pylhe/actions/runs/15856437537/job/44702856720. |
|
Yeah, seems unhappy about the auth I guess? my suggestion is to check to see if there's examples in the GitHub docs to have the auth get setup correctly for workflow dispatch operations, and if not, then fall back to a simpler release workflow like given in https://learn.scientific-python.org/development/guides/gha-pure/. |
|
Hi @matthewfeickert, is the release something you could help out, assuming the workflow still works for you as in the past? I'm quite loaded this week to investigate, as I'm at the EPPSU Open Symposium. (I will put it on my list to look at the release when back next week ... In the end it should be easy, at least things work really smoothly and easily for Particle and DecayLanguage.) |
|
pylhe/.github/workflows/bump-version.yml Lines 42 to 48 in 04f3577
Apparently this uses a Personal access token, maybe it expired (if it did not work for you either). Unfortunately, the default |
|
BTW. I personally prefer to just run the release pipeline whenever a tag is pushed (vX.Y.Z) instead of manually triggering runs. I can restructure the CI to something simpler, if the existing system can not somehow be saved. |
|
Hi. Yep, I also reckon the present system is a bit too complicated. As I said I have things nice and easy for my packages, and @matthewfeickert seems to agree to simplify as well. Let me know if you need help. |
|
I just ran |
|
Happy it worked! |
|
Unfortunately it's not working OK on the conda feedstock, see conda-forge/pylhe-feedstock#13 :(. |
This has been fixed. All good there. |
Closes: #177