Improve .gitignore iteration speed #1103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
os.walk
instead ofPath().rglob
can be 10x faster in deeply nested directory structures. This is a significant saving on certain projects, where just this iteration can take up to 3 or 4 seconds.An even better approach would be to parse gitignore files lazily, as the directory tree is traversed later in this function. Another optimization would be to prune ignored directories while walking the directory tree, so they aren't even explored.
However, just the single optimization in this PR already reduces the impact of this code significantly, bringing it from almost 3s in my profile to just 0.4s.