Skip to content

Would you accept a PR that allowed more access to private vars HashMap in AbstractEvaluator? #21

Description

@JaredDavis22

Hi,

Thanks for this code. I would like to evaluate a series of statements then use the names/values in private HashMap vars to process the result.

The current code allows a get to the vars if the key name is known. It does not provide a method to get the vars keyset as far as I can tell.

Would you accept a PR that adds something like this to AbstractEvaluator?

public Set<String> getNames() {
        return vars.keySet();
}

Am I way off base? I didn't look at the implications of adding getNames() to interface Evaluator. Would that be better?

Thanks!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions