Skip to content

Enhance error handling & logging when container cannot be started. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pruiz wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Enhance error handling & logging when container cannot be started. #4

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f0cbb6
Enhance error handling & logging when container cannot be started.
pruiz Jun 2, 2022
aff5e12
Fixed forgot return clause on finally handler.
pruiz Jun 3, 2022
0194895
And now added the missing return to it's right place.
pruiz Jun 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions kvm_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
)
from nojava_ipmi_kvm.config import config, HTML5HostConfig
from nojava_ipmi_kvm import utils

from tornado.websocket import WebSocketError
from basehandler import BaseWSHandler

WEB_PORT_START = int(os.environ.get("WEB_PORT_START", 8800))
Expand Down Expand Up @@ -60,6 +60,7 @@ async def on_message(self, msg):
return self.write_message({"action": "notice", "message": "Already connected to a kvm!"})
self._connecting = True

started = False
server = msg["server"]
password = msg["password"]
resolution = msg["resolution"] if "resolution" in msg else None
Expand Down Expand Up @@ -119,17 +120,20 @@ def send_log_message(msg, *args, **kwargs):
external_web_dns=external_web_dns, port=self._web_port, hostname=host_config.full_hostname
),
)
except (
WebserverNotReachableError,
DockerNotInstalledError,
DockerNotCallableError,
IOError,
DockerTerminatedError,
DockerPortNotReadableError,
) as ex:
logging.exception("Could not start KVM container")
used_ports.remove(web_port)
started = True
except WebSocketError as ex:
logging.exception("Could not start KVM container: WebSocket closed unexpectedly?")
return
except Exception as ex:
logging.exception("Could not start KVM container: %s" % ex)
return self.write_message({"action": "error", "message": str(ex)})
finally:
try:
if not started:
used_ports.remove(web_port)
self._current_session.kill_process()
except:
pass

if isinstance(sess, HTML5KvmViewer):
return self.write_message(
Expand Down