feat: add chromeFlags, chromePath and --headless as default

Fixes #146 pdf only works in headless mode Fixes #184 Add chromePath and chromeFlags to ChromelessOptions
schickling · Jan 18, 2018 · deb8d40 · deb8d40
1 parent fcdc8dc
commit deb8d40
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/src/api.ts b/src/api.ts
@@ -46,6 +46,7 @@ export default class Chromeless<T extends any> implements Promise<T> {
         closeTab: true,
         ...options.cdp,
       },
+      chromeFlags: ['--headless'],
     }
 
     const chrome = mergedOptions.remote

diff --git a/src/chrome/local.ts b/src/chrome/local.ts
@@ -38,7 +38,9 @@ export default class LocalChrome implements Chrome {
     const { port } = this.options.cdp
     this.chromeInstance = await launch({
       logLevel: this.options.debug ? 'info' : 'silent',
-      port,
+      port: this.options.cdp.port,
+      chromeFlags: this.options.chromeFlags,
+      chromePath: this.options.chromePath,
     })
     const target = await CDP.New({
       port,

diff --git a/src/types.ts b/src/types.ts
@@ -53,6 +53,8 @@ export interface ChromelessOptions {
   launchChrome?: boolean // auto-launch chrome (local) `true`
   cdp?: CDPOptions
   remote?: RemoteOptions | boolean
+  chromeFlags?: Array<string> // ['--headless']
+  chromePath?: string
 }
 
 export interface Chrome {