Resolve conflict between lincuan:patch-1 and sccn:develop in OctaveWrapper #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lincuan
commented
Mar 20, 2025
lincuan
commented
- Adopted the eval approach from develop to ensure compatibility with Octave, as direct method calls may fail due to unsupported struct array returns.
- Added file synchronization (flush and fsync) to address the timing issue noted in patch-1, ensuring pop_saveset completes writing before pop_loadset is called.
- Set delete=True for temporary files to ensure automatic cleanup, avoiding file accumulation.
- Retained TODO and explanatory comments for future reference.
…apper - Adopted the eval approach from develop to ensure compatibility with Octave, as direct method calls may fail due to unsupported struct array returns. - Added file synchronization (flush and fsync) to address the timing issue noted in patch-1, ensuring pop_saveset completes writing before pop_loadset is called. - Set delete=True for temporary files to ensure automatic cleanup, avoiding file accumulation. - Retained TODO and explanatory comments for future reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.