Skip to content

Resolve conflict between lincuan:patch-1 and sccn:develop in OctaveWrapper #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2025

Conversation

liincu4n
Copy link
Contributor

  • Adopted the eval approach from develop to ensure compatibility with Octave, as direct method calls may fail due to unsupported struct array returns.
  • Added file synchronization (flush and fsync) to address the timing issue noted in patch-1, ensuring pop_saveset completes writing before pop_loadset is called.
  • Set delete=True for temporary files to ensure automatic cleanup, avoiding file accumulation.
  • Retained TODO and explanatory comments for future reference.

liincu4n and others added 2 commits March 20, 2025 22:47
…apper

- Adopted the eval approach from develop to ensure compatibility with Octave, as direct method calls may fail due to unsupported struct array returns.
- Added file synchronization (flush and fsync) to address the timing issue noted in patch-1, ensuring pop_saveset completes writing before pop_loadset is called.
- Set delete=True for temporary files to ensure automatic cleanup, avoiding file accumulation.
- Retained TODO and explanatory comments for future reference.
@arnodelorme arnodelorme merged commit 44c7275 into sccn:develop Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants