Improving the pre-commit and making sure that everybody can install eegdash #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All good on the features module. |
|
Thanks @bruAristimunha . Why was the main function removed from main.py? |
bruAristimunha
changed the title
|
Can you please review @arnodelorme, @avivdotan and @dungscout96? We need more tests. |
|
Thanks Bruno. What was the main change that fix the installation issue? I see addition of test files and a lot of reformatting which seems like automatic fixes of the pre-commit hooks which is great. But not sure what the main functional change is. And is the change from main.py to api.py a standard practice? |
|
Yes, It's better if we don't put main.py in python code pattern perspective |
|
As Arnaud is starting a second PR based on this one, I understand that we should apply the merge here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, there were some problems instantiating datasets that were not being captured in CI. I'm adjusting them now and creating a test. In addition, there were several codes that made no sense in the code, comments from old code, which goes against the rules of good versioning.