fix(config): create new scw configuration if not found #4864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyleone
reviewed
Jun 25, 2025
| @@ -290,7 +290,12 @@ The only allowed attributes are access_key, secret_key, default_organization_id, | |||
| configPath := core.ExtractConfigPath(ctx) | |||
| config, err := scw.LoadConfigFromPath(configPath) | |||
| if err != nil { | |||
| return nil, err | |||
| if strings.Contains(err.Error(), "no such file or directory") { | |||
There was a problem hiding this comment.
Could an explicit error be defined and used with error.As here?
There was a problem hiding this comment.
the error returned is
// ConfigFileNotFound indicates that the config file could not be found
type ConfigFileNotFoundError struct {
path string
}
error.As cannot be used unfortunately because the path field is private if errors.As(err, &scw.ConfigFileNotFoundError{path: configPath}) {
There was a problem hiding this comment.
Could the path be exported instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Release note for CHANGELOG:
fix #4661 (comment)