fix(helm): restore Dagster 1.1.21 schema validation - #169
Open
scale-ballen wants to merge 2 commits into
Open
Conversation
scale-ballen
marked this pull request as ready for review
August 7, 2026 17:52
| "type": "string" | ||
| }, | ||
| "$ref": "https://kubernetesjsonschema.dev/v1.18.0/_definitions.json#/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta/properties/annotations" | ||
| "$ref": "https://raw.githubusercontent.com/instrumenta/kubernetes-json-schema/3fb477fb1deb6cc85bbc0cbc2eefc6093f60d6c5/v1.18.0/_definitions.json#/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta/properties/annotations" |
There was a problem hiding this comment.
Schema generator restores dead references
When CI runs dagster-helm schema apply, create_definition_ref regenerates both schemas with the dead kubernetesjsonschema.dev host instead of the newly pinned references, causing git diff --exit-code to fail and reintroducing broken Helm validation if the generated output is accepted.
Prompt To Fix With AI
This is a comment left during a code review.
Path: helm/dagster/values.schema.json
Line: 147
Comment:
**Schema generator restores dead references**
When CI runs `dagster-helm schema apply`, `create_definition_ref` regenerates both schemas with the dead `kubernetesjsonschema.dev` host instead of the newly pinned references, causing `git diff --exit-code` to fail and reintroducing broken Helm validation if the generated output is accepted.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required by scaleapi/Terracode-Infra#8657 and scaleapi/scaleapi#154479.
Dagster 1.1.21 chart schemas reference kubernetesjsonschema.dev. That host now presents a certificate for netlify.app, so Helm 3.12.1 rejects the chart before values are validated or manifests are rendered.
This change:
Validation:
Keep draft until the companion migration rollout is ready.
Greptile Summary
This PR restores Dagster 1.1.21 Helm schema loading by replacing the unavailable Kubernetes schema host with commit-pinned GitHub references and publishing a rebuilt chart through a branch-local index.
Confidence Score: 4/5
The PR should not merge until the schema generator emits the new pinned references, otherwise the generated-schema CI check fails.
The committed schemas use the replacement host, while the generator still emits the dead host and CI explicitly regenerates the files before requiring a clean diff.
Files Needing Attention: helm/dagster/values.schema.json, helm/dagster/charts/dagster-user-deployments/values.schema.json, helm/dagster/schema/schema/charts/utils/utils.py
Important Files Changed
create_definition_ref.Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "fix(helm): pin Kubernetes schema source" | Re-trigger Greptile