Feature/compiler plugin backend indexing #1626
Open
+87
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce CompilerPlugin in Platform.scala - Update BinaryVersion.toString to handle CompilerPlugin - Update all platform matches in Artifact.scala to explicitly handle CompilerPlugin - Throw UnsupportedOperationException where features aren’t implemented - Add unit test for creating Artifact with CompilerPlugin - Lints clean
- Update indexing logic to include CompilerPlugin artifacts - Add database migration for CompilerPlugin if required - Ensure queries return correct versions and metadata - Add unit/integration tests for CompilerPlugin indexing
adpi2
reviewed
Nov 16, 2025
Member
adpi2
left a comment
adpi2
left a comment
There was a problem hiding this comment.
Thank you @vidishagawas121 for your work. This is a good start but it does not yet allow parsing an artifact ID with a full Scala version as the binary version, such as kind-projector_2.13.16.
modules/core/shared/src/test/scala/scaladex/core/model/ArtifactTests.scala
Outdated
Show resolved
Hide resolved
modules/infra/src/test/scala/scaladex/infra/ElasticsearchEngineTests.scala
Outdated
Show resolved
Hide resolved
modules/core/shared/src/main/scala/scaladex/core/model/Platform.scala
Outdated
Show resolved
Hide resolved
adpi2
approved these changes
Nov 17, 2025
| for | ||
| _ <- insertAll(projects) | ||
| platforms <- searchEngine.countByPlatforms(params) | ||
| yield platforms should contain(CompilerPlugin -> 1L) |
Member
There was a problem hiding this comment.
This should be CompilerPlugin(Version(2, 13, 16))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh pr create
--title "Backend: Index CompilerPlugin artifacts"
--body "This PR adds backend support for indexing CompilerPlugin artifacts in Scaladex.
This PR depends on PR 1, which introduced CompilerPlugin in the models."
--base main
--head feature/compiler-plugin-backend-indexing