Skip to content

Store position in layer space when double-clicking segment #9017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 29, 2025
Merged

Store position in layer space when double-clicking segment #9017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7b615c1
store global position when double-clicking segment
knollengewaechs Oct 23, 2025
62461e2
changelog
knollengewaechs Oct 23, 2025
338769e
fix typo in changelog
knollengewaechs Oct 23, 2025
a42c5b5
Merge branch 'master' into fix-segment-position-double-click
knollengewaechs Oct 27, 2025
f7877e9
Merge branch 'master' into fix-segment-position-double-click
knollengewaechs Oct 27, 2025
a552e16
Merge branch 'master' into fix-segment-position-double-click
knollengewaechs Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions frontend/javascripts/viewer/controller/combinations/volume_handlers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,22 @@ export function handlePickCellFromGlobalPosition(
if (segmentId === 0) {
return;
}
Store.dispatch(setActiveCellAction(segmentId, globalPos, additionalCoordinates));

const visibleSegmentationLayer = getVisibleSegmentationLayer(Store.getState());

const positionInLayerSpace =
visibleSegmentationLayer != null
? globalToLayerTransformedPosition(
globalPos,
visibleSegmentationLayer.name,
"segmentation",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a little confused by the plain string "segmentation" here at first. @philippotto Do we maybe want to refactor this into an enum, so we can write something like LayerType.Segmentation or so? This would have made this upon first read easier to understand / not stumble upon.

=> But this refacoring shouldn't be done here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, this comment slipped through in my mail box. yes, sounds like a good idea. we should be careful about the naming though. I think, it's often called "category".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I opened a short issue fore this: #9035

Store.getState(),
)
: null;

Store.dispatch(
setActiveCellAction(segmentId, positionInLayerSpace || globalPos, additionalCoordinates),
);

if (visibleSegmentationLayer == null) {
return;
}
Expand Down
6 changes: 5 additions & 1 deletion frontend/javascripts/viewer/view/context_menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1430,7 +1430,11 @@ function getNoNodeContextMenuOptions(props: NoNodeContextMenuProps): ItemType[]
key: "select-cell",
onClick: () => {
Store.dispatch(
setActiveCellAction(segmentIdAtPosition, globalPosition, additionalCoordinates),
setActiveCellAction(
segmentIdAtPosition,
positionInLayerSpace || globalPosition,
additionalCoordinates,
),
);
},
disabled:
Expand Down
3 changes: 3 additions & 0 deletions unreleased_changes/9017.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
### Fixed
- Double-clicking a registered segment now stores its position in the segment's layer coordinate system, preserving correct behaviour when layer transforms are in use.