Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster Mesh Rendering and Raycasting in 3D viewport #8106

Open
wants to merge 73 commits into
base: master
Choose a base branch
from
+1,968 −1,189
Open

Faster Mesh Rendering and Raycasting in 3D viewport #8106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
73 commits
Select commit Hold shift + click to select a range
8822f1d
Upgrade threejs to v0.169. Add three-mesh-bvh library and use it to s…
daniel-wer Sep 30, 2024
fcc3f3b
log timing
fm3 Sep 30, 2024
2afee22
log duration for raycaster
fm3 Sep 30, 2024
0e2636a
save some backend perf in chunk list request
fm3 Sep 30, 2024
a5efc3a
Update BufferGeometryUtils. Merge all geometries of a precomputed mes…
daniel-wer Sep 30, 2024
05b6647
Merge branch 'faster-caster' of github.com:scalableminds/webknossos i…
daniel-wer Sep 30, 2024
852fc2f
Merge all geometries of each mesh respectively
daniel-wer Sep 30, 2024
36f5c0f
throttling delay 0, weil das ja klar is
fm3 Sep 30, 2024
b87610b
Revert "throttling delay 0, weil das ja klar is"
daniel-wer Sep 30, 2024
2bbd009
remove logging in raycaster
fm3 Sep 30, 2024
80a53fe
Merge branch 'faster-caster' of github.com:scalableminds/webknossos i…
fm3 Sep 30, 2024
5f279e7
Revert "Merge all geometries of each mesh respectively"
daniel-wer Oct 1, 2024
65cbc5e
revert mesh merging
daniel-wer Oct 1, 2024
8a2bea9
Merge branch 'faster-caster' of github.com:scalableminds/webknossos i…
daniel-wer Oct 1, 2024
77f2986
fix mergeBufferGeometries
daniel-wer Oct 1, 2024
08e8de3
fix mergeBufferGeometries
daniel-wer Oct 1, 2024
67cd905
Remove unnecessary react-debounce-render lib
daniel-wer Oct 1, 2024
915e589
optimize chunkinfo merge, chunk request reads
fm3 Oct 1, 2024
a0d8734
further optimize chunk loading reads
fm3 Oct 1, 2024
81f8de7
restore file exists check
fm3 Oct 1, 2024
1d7acef
Merge branch 'faster-caster' of github.com:scalableminds/webknossos i…
daniel-wer Oct 1, 2024
4c899bb
Revert "revert mesh merging"
daniel-wer Oct 1, 2024
57c1522
Reapply "Merge all geometries of each mesh respectively"
daniel-wer Oct 1, 2024
bc9d8e1
Add window.DEBUG_BVH flag and don't use groups when merging geometrie…
daniel-wer Oct 1, 2024
7fb264d
less logging
fm3 Oct 1, 2024
c5c3e94
remove backend changes from this PR, they are moved to https://github…
fm3 Oct 2, 2024
1f964fe
Merge branch 'master' of github.com:scalableminds/webknossos into fas…
philippotto Mar 10, 2025
7d97431
small clean up
philippotto Mar 10, 2025
72dd4f3
fix colors and improve lighting
philippotto Mar 10, 2025
2e40c55
fix aggressive pop up when deleting a single tree via context menu
philippotto Mar 10, 2025
32c7f1b
misc
philippotto Mar 10, 2025
ed6f149
wip: use vertex colors to highlight parts of a mesh; use cumulative i…
philippotto Mar 11, 2025
21a56f3
add more todo comments
philippotto Mar 11, 2025
dfcaa44
fix selecting/highlighting super voxels in proofreading mode
philippotto Mar 11, 2025
4681b41
remove mergeChunks and isMerged booleans because these are always tru…
philippotto Mar 11, 2025
dba67e7
restore hover behavior for non-proofreading (whole mesh should be hig…
philippotto Mar 11, 2025
4ae7353
implement webknossos.DEV.benchmarkRotate()
philippotto Mar 11, 2025
b829eb5
Merge branch 'master' of github.com:scalableminds/webknossos into fas…
philippotto Mar 11, 2025
bdc94ee
clean up more isMerged stuff
philippotto Mar 12, 2025
fe461da
fix multiSelectMenu performance part of #7895 (which was already clos…
philippotto Mar 12, 2025
a368484
use binary search instead of extra unmappedSegmentId BufferAttribute
philippotto Mar 12, 2025
5a6b584
offload bvh computation to webworker
philippotto Mar 12, 2025
6f6f65a
fix hovering for ad hoc meshes
philippotto Mar 12, 2025
5feda5d
more clean up (e.g., don't group by position anymore)
philippotto Mar 12, 2025
87e84c1
fix changing mesh colors when segment color changes
philippotto Mar 12, 2025
60d0777
refactor
philippotto Mar 12, 2025
b6a3f4b
more clean up
philippotto Mar 12, 2025
bd4f5ff
restore progressive loading behavior (already add partial meshes duri…
philippotto Mar 13, 2025
ff4d540
temporarily disable ci
philippotto Mar 13, 2025
958f102
update mesh bvh to 0.9.0
philippotto Mar 13, 2025
dcd870a
restore url hash parsing
philippotto Mar 13, 2025
0a98dae
re-add throttling to avoid lags when meshes are not yet merged
philippotto Mar 17, 2025
dbd36a6
fix types in VisibilityAwareRaycaster
philippotto Mar 17, 2025
0a1da5b
fix typing
philippotto Mar 17, 2025
7746d2c
re-enable ci
philippotto Mar 17, 2025
f21f5b4
update changelog
philippotto Mar 17, 2025
2280c39
format
philippotto Mar 17, 2025
5774348
cherry pick ignoreWarnings from #8389
philippotto Mar 17, 2025
b0c7316
bump webpack deps
philippotto Mar 18, 2025
8c8dd79
mock compute_bvh_async due to esm problems
philippotto Mar 18, 2025
250a188
remove lil-gui
philippotto Mar 18, 2025
7805480
fix cyclic dependencies
philippotto Mar 18, 2025
0cf7ec6
lint
philippotto Mar 18, 2025
b4d0a8c
Merge branch 'master' of github.com:scalableminds/webknossos into fas…
philippotto Apr 3, 2025
6c6d00b
incorporate some PR feedback
philippotto Apr 3, 2025
740fe8b
inline setColor function
philippotto Apr 3, 2025
6f7340f
remove gui
philippotto Apr 3, 2025
8ec7e0c
clean up
philippotto Apr 3, 2025
b14dff4
improve rotate benchmark so that actual measurements are done; remove…
philippotto Apr 4, 2025
96dadfe
remove raycasting perf measurement
philippotto Apr 4, 2025
cc18763
refactor getMeshVisibilityStateForSegments so that local state is not…
philippotto Apr 4, 2025
8cb5e68
clean up (remove opacity change on hover altogether, as it's not crit…
philippotto Apr 4, 2025
c019b3c
add assertions
philippotto Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.unreleased.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released
- Performance improvements for volume annotation save requests. [#8460](https://github.com/scalableminds/webknossos/pull/8460)

### Changed
- Improved speed of mesh rendering and mouse interaction in 3D viewport. [#8106](https://github.com/scalableminds/webknossos/pull/8106)

### Fixed
- Fixed visual alignment of actions in ai model list. [#8474](https://github.com/scalableminds/webknossos/pull/8474)
Expand Down
Loading