Skip to content

Commit

Permalink
step up to http api version 8 (#8142)
Browse files Browse the repository at this point in the history
Co-authored-by: MichaelBuessemeyer <[email protected]>
  • Loading branch information
fm3 and MichaelBuessemeyer authored Oct 23, 2024
1 parent bedb16e commit 7099fe3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .github/common_edge_cases.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,5 @@ Consider SQL pitfalls:
- `x IN ()` statements must never called with empty list
- `ARRAY_AGG(x)` may have nullable values (use `ARRAY_REMOVE(ARRAY_AGG(x), null)` instead)
- Complex SQL queries may have a fanout effect due to multiple left joins, leading to duplicates

When changing the API version, also adapt `ApiVersioning.CURRENT_API_VERSION`
2 changes: 1 addition & 1 deletion app/utils/ApiVersioning.scala
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import play.api.mvc.RequestHeader

trait ApiVersioning {

protected def CURRENT_API_VERSION: Int = 7
protected def CURRENT_API_VERSION: Int = 8

protected def OLDEST_SUPPORTED_API_VERSION: Int = 3

Expand Down

0 comments on commit 7099fe3

Please sign in to comment.