Skip to content

Conversation

normanrz
Copy link
Member

@normanrz normanrz commented Sep 8, 2025

Description:

  • Uses UPath(..., endpoint_url="..") instead of UPath(..., client_kwargs={"endpoint_url":".."}). This requires a change in Voxelytics.
  • Adds more restrictions on fs-based mag copy
  • The add_* methods in Attachments now return the created attachment objects, similar to add_layer and add_mag.

Todos:

  • Updated Changelog

Copy link

github-actions bot commented Sep 8, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
9967 8382 84% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
webknossos/webknossos/cli/_utils.py 67% 🟢
webknossos/webknossos/cli/check_equality.py 89% 🟢
webknossos/webknossos/dataset/dataset.py 76% 🟢
webknossos/webknossos/dataset/layer/layer.py 86% 🟢
webknossos/webknossos/dataset/layer/segmentation_layer/attachments/attachments.py 86% 🟢
webknossos/webknossos/dataset/layer/view/_array.py 88% 🟢
webknossos/webknossos/dataset/layer/view/view.py 89% 🟢
webknossos/webknossos/utils.py 74% 🟢
TOTAL 82% 🟢

updated for commit: 61f4546 by action🐍

@normanrz normanrz self-assigned this Sep 10, 2025
@normanrz normanrz changed the title Copy with s3fs Copy refactorings Sep 10, 2025
@normanrz normanrz marked this pull request as ready for review September 17, 2025 08:27
@normanrz
Copy link
Member Author

There seems to be an issue on this branch with coverage reporting, which leads to a dirty repository in the CI. I need more time to debug this, so I extracted the conditional-write-disable into #1368.

@normanrz normanrz added this to the 3.x milestone Oct 8, 2025
@AndreaNathansen AndreaNathansen requested a review from fm3 October 9, 2025 13:53
@normanrz normanrz enabled auto-merge (squash) October 10, 2025 11:12
@normanrz normanrz merged commit 600af1a into master Oct 10, 2025
23 checks passed
@normanrz normanrz deleted the copytree branch October 10, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants