Mention named givens in double def explainer #23833
Conversation
|
As mentioned at #23121, there are other cases of clashing invented names that are not double defs because the for comprehension desugars them to locals and pattern vars. |
tests/neg/i23832a.check
Outdated
| | | ||
| | To fix this error, you need to disambiguate the two definitions. You can either: | ||
| | | ||
| | 1. Rename one of the definitions, or |
There was a problem hiding this comment.
When the error is reported for given, the first point seems redundant to me. Can we replace it in this case?
Print info at typer in example code. Could be automatic.
som-snytt
force-pushed
the
issue/23832-doubled-given
branch
from
e6c9c95 to
6fe3abc
Compare
|
The purpose of this extra help is to clarify that "anonymous" givens have names, albeit invented ones, and that it turns out to be necessary to name at least one of them explicitly. The example is to prompt the user as to what such a name looks like. Maybe they have never written a named given. Hopefully the example gives them enough information to prompt copilot in turn. That is, it is not a goal of the addendum to be complete or pastable. It ought to be approximately correct. |
Print info at typer in example code. Could be automatic.
Note the sig test must not be at typer.
Fixes #23832