[chore] Fix detecting available nightly versions in bisect script. #23802
Conversation
…po contains only artifacts published after 2025-08-18
|
The intent is to have maven central also accessible via the new repo, I had permission issues when configuring it during Scala Days and I haven't yet fixed them. This should cover for this PR. |
I belive the repo.scala-lang already can delegate to Maven Central for missing artifacts, however, in this case we're extracting the |
I'll let you see the |
…rsion to support 3.8 nightlies
| @@ -133,7 +133,7 @@ object ValidationScript: | |||
| def tmpScalaCliScript(command: String, args: Seq[String]): File = tmpScript(s""" | |||
| |#!/usr/bin/env bash | |||
| |export JAVA_HOME=${sys.props("java.home")} | |||
| |scala-cli ${command} -S "$$1" --server=false ${args.mkString(" ")} | |||
| |scala-cli --cli-version=1.9.0 ${command} -S "$$1" --server=false ${args.mkString(" ")} | |||
There was a problem hiding this comment.
hardcoding --cli-version=1.9.0 here will always enforce the JVM launcher... which is slightly slower than its native counterparts.
That being said, it does ensure the script will work for everyone. 🤔
There was a problem hiding this comment.
A potential improvement would be to check for the version of scala-cli being used
This command will print the launcher version, only
scala-cli version --cli-versionAnd then if it's <1.9.0, print a warning and default to the --cli-version override.
There was a problem hiding this comment.
If you deem it out of scope for this PR, feel free to leave it like this and raise the improvement as an issue.
There was a problem hiding this comment.
This is not necessary anymore. https://repo.scala-lang.org now proxies Maven Central too as I intended in the first place. @WojciechMazur can you please verify that the script work without the proposed changes here? Thanks.
The new repo contains only artefacts published after 2025-08-18, we need to parse maven-matadata from the old repository to get the full list of available nightlyies