Backport "Bump Scala CLI to v1.8.4 (was v1.8.3)" to 3.7.2 #23547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The body of isLegalPrefix used to read:
pre.isStable || !ctx.phase.isTyper
but was changed to drop the second condition in #21954 (originally included in
3.6.4-RC1, reverted from 3.6.4 final but back in 3.7). This has led to a
number of regressions, the last ones discussed in #23423.
To make the testcases added in #21594 pass, this PR proposes a less drastic
change: relax isLegalPrefix as before, unless we're doing an implicit search.
This should dramatically reduce the possibility for regressions.
Fixes #23423.
Fixes #22676.
[Cherry-picked 2e4bc0a]
They were previously fixed from crashing to erroring state, now compiling. The cause of the previous crashes looks the same as the one fixes in this PR, where the stale synthetic top level package object would be brought forward, causing other stale symbols to be used. [Cherry-picked 08b8340]
Fixes #23494 When inspecting unused implicit parameters, the check skips parameters which are "marker traits". It tests for any members of the type (or its upper bound) which are not "universal members". This commit uses the `resultType` to avoid an error ``` invalid new prefix ``` while computing members where the type is a `LambdaType`. A future improvement would be not to request `allMembers`, since the check only needs to find one that is not universal. The necessitating change was 2e4bc0a. [Cherry-picked a5e15ab]
[Cherry-picked 48305ac][modified]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #23538 to the 3.7.2-RC2.
PR submitted by the release tooling.
[skip ci]