Fix line and path separators in test #23534
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A NL is dropped from check files of bootstrapped neg-macros but it's not obvious how to supply the update flag. Edit: just |
som-snytt
force-pushed
the
issue/23458-update-check
branch
from
db2c829 to
31b4fd4
Compare
|
Spurious windows_fast failure. |
som-snytt
force-pushed
the
issue/23458-update-check
branch
from
31b4fd4 to
c6fa07f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23458
Splitting on NL leaves the CR if present. Just use
linesIterator.Introduce a template method for rendering paths. The test reporter replaces windows convention.
Previously, a
TestReporterwith empty console output would contribute a NL because"".split("\n")is not empty. (There is a test reporter per compilation group.)