Skip to content

bugfix: Check for error before checking members of product type in getUnapplySelectors #23358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

bugfix: Check for error before checking members of product type in getUnapplySelectors #23358

wants to merge 3 commits into from

Conversation

aherlihy
Copy link
Contributor

Fixes #23156

I'm not 100% sure this is the best way to check for error types, so would appreciate any guidance!

EugeneFlesselle
EugeneFlesselle reviewed Jun 13, 2025
View reviewed changes
Copy link
Contributor

@EugeneFlesselle EugeneFlesselle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks liks we're diverging in Applications.productSelectorTypes, so I think we should move the check there in case a similar problem occurs coming from some other path.
Otherwise this seems like the correct way to check for ErrorTypes AFAIK 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EugeneFlesselle EugeneFlesselle EugeneFlesselle left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler goes OOM/infinite loop after unknown type in extractor
2 participants
@aherlihy @EugeneFlesselle