Skip to content

chore: add language import in stdlib #23102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hamzaremmal
Copy link
Member

@hamzaremmal hamzaremmal commented May 5, 2025

We add the scala.language.2.13 import in all the files from Scala 2 stdlib

@hamzaremmal hamzaremmal added this to the 3.8.0 milestone May 5, 2025
@hamzaremmal hamzaremmal self-assigned this May 5, 2025
@hamzaremmal hamzaremmal force-pushed the add-language-import-stdlib branch from 6a6b8ce to 1cbd192 Compare May 5, 2025 16:38
@hamzaremmal hamzaremmal requested review from sjrd and natsukagami May 5, 2025 16:41
Copy link
Contributor

@natsukagami natsukagami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a glance through every file, looks fine to me.

hamzaremmal added a commit that referenced this pull request May 19, 2025
@hamzaremmal hamzaremmal deleted the branch scala:hr/main-with-stdlib May 20, 2025 09:13
@hamzaremmal hamzaremmal reopened this May 20, 2025
@hamzaremmal hamzaremmal force-pushed the add-language-import-stdlib branch from 1cbd192 to a3065b5 Compare May 20, 2025 09:31
@hamzaremmal hamzaremmal changed the base branch from embed-stdlib to hr/main-with-stdlib May 20, 2025 09:32
@hamzaremmal hamzaremmal merged commit 5260065 into scala:hr/main-with-stdlib May 22, 2025
15 of 30 checks passed
@hamzaremmal hamzaremmal deleted the add-language-import-stdlib branch May 22, 2025 19:05
@hamzaremmal hamzaremmal restored the add-language-import-stdlib branch July 16, 2025 09:26
hamzaremmal added a commit that referenced this pull request Jul 16, 2025
This is a port of #23102 to the actual `main` branch.
---

In this PR, we add the import `scala.language.2.13` to each and every
file in the stdlib that originated from Scala 2.13.
The flag changes the behavior of certain part of the compiler to produce
code as if we were compiling with Scala 2.13's semantics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants