Skip to content

Call dealias after stripping type variables for tupleElementTypesUpTo #23005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 17, 2025

Conversation

aherlihy
Copy link
Contributor

Fixes #22643 and the first test case of #22645.

Copy link
Contributor

@EugeneFlesselle EugeneFlesselle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appears you also fixed #22645 (including the ExhibitE) 👍, I think we can close it as solved with this PR too

@aherlihy
Copy link
Contributor Author

aherlihy commented Apr 17, 2025

ExhibitE is weird for me, running this test case crashes the compiler (also on main) only when run from the pickling tests in testCompilation, so normal use bin/scalac tests/pos/i22645b.scala does not cause a compiler crash.
From testCompilation, it crashes with:

[info] Test dotty.tools.dotc.CompilationTests.pickling started
[                                        ] completed (0/1, 0 failed, 1s)
Fatal compiler crash when compiling: tests/pos/i22645b.scala:
pickling difference for object ExhibitE in tests/pos/i22645b.scala 

That looks like an unrelated pickling issue that may need a separate ticket.

@EugeneFlesselle
Copy link
Contributor

That looks like an unrelated pickling issue with the test suite that may need a separate ticket.

Oh, that tends to happen with match types, you can add the test case to the pos-test-pickling.excludelist.

@aherlihy
Copy link
Contributor Author

Oh great, thanks! Added the test case back now, I'll close both issues when this is PR is done

@aherlihy aherlihy enabled auto-merge April 17, 2025 09:12
@aherlihy aherlihy merged commit ac47299 into scala:main Apr 17, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combination of trait, type alias, Tuple.Concat, and named tuple, where named tuple elements are not selectable
2 participants