Use other tree for actual symbol of Assign #22869
Conversation
som-snytt
force-pushed
the
issue/22671-assignment-error
branch
from
cbdcdd5 to
ef97824
Compare
| |Also, assignment syntax can be used if there is a corresponding setter: | ||
| | ${hl("def")} ${name}${hl("_=(x: Int): Unit = _v = x")} |
There was a problem hiding this comment.
I wouldn't add this one here. The sugaring for setters is very very scope specific and fragile. It cannot be summarized into the assignment syntax can be used if there is a corresponding setter...
There was a problem hiding this comment.
I think some words are necessary for user who needs an explanation; I restricted it to class members.
| class ReassignmentToVal(name: Name)(using Context) | ||
| extends TypeMsg(ReassignmentToValID) { | ||
| def msg(using Context) = i"""Reassignment to val $name""" | ||
| def msg(using Context) = i"""Reassignment to value $name""" |
There was a problem hiding this comment.
We could actually pass the symbol instead of the name and we would either get val, def,... depending on the actual symbol.
som-snytt
force-pushed
the
issue/22671-assignment-error
branch
from
ef97824 to
76c6790
Compare
|
I started down the long tail of polishing words. Let the symbol say what it is, and restrict setter explanation to class-owned symbols. (Need to check class params.) |
som-snytt
force-pushed
the
issue/22671-assignment-error
branch
2 times, most recently
from
7785a12 to
21d48c8
Compare
som-snytt
force-pushed
the
issue/22671-assignment-error
branch
from
21d48c8 to
1187728
Compare
|
Updated the branch from March, which had the spree contributors. Improved to include the pathology from That test also suggested providing the args, which I took to mean show I ran out of steam and did not add the scala 2 explanation, that |
som-snytt
force-pushed
the
issue/22671-assignment-error
branch
from
1187728 to
fb79c19
Compare
tests/neg/i22671.check
Outdated
| -- [E052] Type Error: tests/neg/i22671.scala:20:4 ---------------------------------------------------------------------- | ||
| 20 | y = 27 // error | ||
| | ^^^^^^ | ||
| | Assignment to method x |
There was a problem hiding this comment.
Seems like the renaming isn't taken into account here.
There was a problem hiding this comment.
I think that was intentional, though it could be improved
Assignment to y which is a renaming of method x
or
Assignment to method x imported as y // closer to user syntax
Co-authored-by: Jan-Pieter van den Heuvel <[email protected]> Co-authored-by: Seth Tisue <[email protected]> Co-authored-by: Lucas Nouguier <[email protected]> Co-authored-by: Prince <[email protected]>
It must have been imported; say so for clarity. Use current syntax in explanatory examples; don't use very fake code but prefer /* code */. Some LOC are made shorter for reading.
som-snytt
force-pushed
the
issue/22671-assignment-error
branch
from
fb79c19 to
a9a08b4
Compare
Fixes #22671
Scala 2 says that the setter was not found.
For
+=it will add what error caused "convert to assignment" to fail. I added a test but not the addendum.The Scala 3 message text is tweaked. (A def is not a val, so just say "value".)
Scala 2 omits the name, since the caret points to the name, but supplying the name is useful if it is different from what is written.