Skip to content

Add code tabs to fun-write-method-returns-function #2664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 9, 2023

Conversation

doehyunbaek
Copy link
Contributor

@doehyunbaek doehyunbaek commented Jan 1, 2023

With c875c65 I updated Gemfile.lock.

Is it needed or better not tracked in git? I assumed the former from the previous commits to the file and if i misunderstood it I'll revert and force push the change.

With 60a87c4, I updated code tab, per #2481.

I tested each code with 2.13.10 repl and 3.2.1 repl and tested the website with jekyll

Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @doehyunbaek for your help!

I just noticed one minor possible improvement.

@doehyunbaek
Copy link
Contributor Author

I added the for attribute because of this mention and should it also be updated?

@doehyunbaek
Copy link
Contributor Author

I rebased onto origin/main and force-pushed branch.

Gemfile.lock Outdated
@@ -91,4 +94,4 @@ DEPENDENCIES
webrick (~> 1.7)

BUNDLED WITH
2.3.10
2.4.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this version change for the bundler. Here we use 2.3.10:

RUN gem install bundler:2.3.10 jekyll

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give me a brief advice on when to commit Gemfile.lock file change? It seems always is not the option. So is it never? or for some portion of the lock file(e.g. except bundler version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with fc15ab3, would still appreciate your advice.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the lockfile should always be committed, but the file should be generated with the right version of the bundler. Could you please make sure to have bundler 2.3.10 on your system, or to use the Docker approach to automatically use the correct version of the bundler?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually have bundler 2.3.10 installed at my local mac. Strange it changed the lockfile.

I will try to commit lockfile with correct bundler version as specified in Dockerfile and will use the Docker approach if I'm not able to do that.

@julienrf
Copy link
Contributor

julienrf commented Jan 5, 2023

Thank you for updating the PR. I don’t think the documentation should be updated, the advice explaining the possibility of adding the for property when that helps readability still applies.

@julienrf julienrf merged commit aaa9a2d into scala:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants