Remove 1.x deprecatia #557
Conversation
|
Yeah idk, I was wondering about this too. It might be nicer for the migration to leave all in the 1.x deprecated stuff around in 2.x just so that it's really easy to upgrade. OTOH we could instruct everybody to upgrade to 1.2.0 first and make sure they aren't depending on anything deprecated, before upgrading. I don't think that would be unreasonable, but we could go either way. Option 2 (i.e. this PR) would be nicer for us.... |
|
We can revisit this before we release or feel free to close! |
|
Also maybe we could do some of this. Like I think one of these is a method that was added in error so IDK how anyone could actually use that code, I'd love to purge it. |
| @deprecated("This method seems to have been added in error and not actually exist.", "1.2.0") | ||
| def close(): Unit = js.native | ||
|
|
There was a problem hiding this comment.
Yep. This should definitely go IMO.
I'll take you up on the feel free to close part. Let's revisit later |
Not sure if it's too soon for this since 1.2.0 is still fresh. But if not now, then when? :)