Pull? #6
Merged
Pull? #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
November 13, 2010 15:21
set slf4j simple for testscope and first to get logging in test
|
All looks good. One question though - how does using Java 5 instead of Java 6 affect the annotation support that I've included? |
|
annotations came with java5 so that should be fine |
|
They were enhanced in Java 6 though. Then again, it all builds and the unit tests pass so it should be fine anyway :) |
|
BTW: Any thoughs on using http://nexus.sonatype.org/oss-repository-hosting.html to push to central? |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi - would you like to pull my changes?
it contains spring upgrade, switch of logging to slf4j and some minor maven configs.
BTW: What do you think about doing this: https://docs.sonatype.org/display/Repository/Sonatype+OSS+Maven+Repository+Usage+Guide to get the artifact out on maven central?