-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade webpack-dev-server from 3.1.4 to 4.8.0 #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-IP-12704893 - https://snyk.io/vuln/SNYK-JS-IP-12761655
Summary of ChangesHello @saurabharch, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the project's security posture by updating a critical development dependency. It specifically targets and resolves two high-severity Server-side Request Forgery vulnerabilities found in Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR upgrades webpack-dev-server
to v4.8.0 to address security vulnerabilities. However, this is a major version upgrade with significant breaking changes. The current implementation will break the development server (npm start
or yarn start
). I've added a critical comment detailing the necessary code changes in packages/react-scripts/scripts/start.js
and packages/react-scripts/config/webpackDevServer.config.js
to make the project compatible with webpack-dev-server
v4.
"url-loader": "1.0.1", | ||
"webpack": "4.8.3", | ||
"webpack-dev-server": "3.1.4", | ||
"webpack-dev-server": "4.8.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading webpack-dev-server
to version 4.x is a major breaking change that will cause the development server to fail with the current configuration.
The following files need to be updated to be compatible with webpack-dev-server
v4:
-
packages/react-scripts/scripts/start.js
:- The
WebpackDevServer
constructor arguments have been swapped. On line 109,new WebpackDevServer(compiler, serverConfig)
must be changed tonew WebpackDevServer(serverConfig, compiler)
.
- The
-
packages/react-scripts/config/webpackDevServer.config.js
:disableHostCheck
andpublic
: These are removed. UseallowedHosts
instead. The logic for setting this needs to be migrated carefully from the old options.clientLogLevel
: Renamed toclient.logging
. For example,clientLogLevel: 'none'
becomesclient: { logging: 'none' }
.contentBase
: Removed. Usestatic: { directory: ... }
.watchContentBase
: Removed. Usestatic: { watch: ... }
.publicPath
: Moved todevMiddleware.publicPath
.quiet
: Removed. This is now the default behavior for logging.overlay
: Moved toclient.overlay
.before
: Renamed toonBeforeSetupMiddleware
. The function now receives thedevServer
instance, so you'd usedevServer.app
instead of theapp
argument.
Without these changes, the application's start script will break. This is a critical issue that needs to be addressed along with the version bump.
Snyk has created this PR to fix 2 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):
packages/react-scripts/package.json
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-IP-12704893
SNYK-JS-IP-12761655
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Server-side Request Forgery (SSRF)