Stringify paths to unique paths correctly #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PikachuEXE
reviewed
Jan 23, 2017
lib/sassc/rails/importer.rb
Outdated
| @@ -94,7 +94,9 @@ def imports(path, parent_path) | |||
| return glob_imports(base, m[2], parent_path) | |||
| end | |||
|
|
|||
| search_paths = ([parent_dir] + load_paths).uniq | |||
| # Compass and other gems us their own special loaders | |||
|
Updated thanks @PikachuEXE |
|
But the build failed :S |
|
well 💩 I'll look at it |
|
It appears that sassc/sass has changed how line_comments show up relative to this test. It was reporting: I did fix it as is but I believe it would actually be better to change the test to check on the first path which seems to make more sense to me. Though that's up to you @PikachuEXE |
|
I know nothing about the test |
The problem here is that gems like compass-sass and bootstrap-sass will build their own Importer classes that aren't being properly uniqued. Also this resolves the issue outlined in sass#79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem here is that gems like compass-sass and bootstrap-sass will
build their own Importer classes that aren't being properly uniqued.
This will resolve #79