Triage more specs for Dart Sass. #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
force-pushed
the
triage
branch
2 times, most recently
from
5ff0be9 to
8708180
Compare
This marks the spec as TODO for Ruby Sass.
The deleted tests had large inputs in which one line errored and all other lines were ignored, and as such weren't particularly useful. New specs should be added for these; see #1013.
This marks specs that include color arithmetic as incompatible with 4.0, and adds 4.0-specific specs that assert color arithmetic failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update specs to match the new behavior introduced by Dart Sass.