Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed path serialization issue #72

Merged
merged 1 commit into from
May 16, 2024

Conversation

akulyakhtin
Copy link
Contributor

Jackson serializes paths as absolute paths.
Creating URL from absolute path fails on WIndows because of the drive letter followed by a column in absolute path.

Because of this tests HttpMultipartTest.testToByteArrays and HttpProcessorTest.shouldReturnAnObjectWhenMethodIsAnnotatedWithMultipart failed.

Also some simple-open-ai functionality was broken as indicated in sashirestela/simple-openai#133

This fix uses URIs instead of URL.

Best regards,
Alex

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.90%. Comparing base (ac67bd9) to head (d75a717).

Files Patch % Lines
...shirestela/cleverclient/support/HttpMultipart.java 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #72   +/-   ##
=========================================
  Coverage     95.89%   95.90%           
  Complexity      295      295           
=========================================
  Files            35       35           
  Lines           804      805    +1     
  Branches         74       74           
=========================================
+ Hits            771      772    +1     
  Misses           18       18           
  Partials         15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sashirestela sashirestela merged commit d6f8127 into sashirestela:main May 16, 2024
2 checks passed
@akulyakhtin akulyakhtin deleted the bug/windows_file_path branch May 16, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants