Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default query parameters that are appended to every URL #39

Closed
wants to merge 2 commits into from
Closed

Conversation

the-gigi
Copy link
Contributor

@the-gigi the-gigi commented Feb 9, 2024

This necessary to allow simple-openai to support Azure Open AI. See sashirestela/simple-openai#3

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (10a52b9) 96.39% compared to head (0de333d) 96.45%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #39      +/-   ##
============================================
+ Coverage     96.39%   96.45%   +0.05%     
- Complexity      235      239       +4     
============================================
  Files            29       29              
  Lines           611      620       +9     
  Branches         62       65       +3     
============================================
+ Hits            589      598       +9     
  Misses           12       12              
  Partials         10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sashirestela
Copy link
Owner

sashirestela commented Feb 9, 2024

@the-gigi

This library was technically designed to be based on using interfaces to define all the request parameters (headers, query parameters, path parameters, body parameters). Allowing to enter additional query parameters explicitly will be against that technical design. However, there are exceptional scenarios that we need to handle in some way, but we need a general approach that will be aligned with the original design and don't compete with it. In that sense, I have developed the Url Interceptor mechanism to be used just on exceptional scenarios: #40

I hope you could see the advantages of this general approach and you could use it to handle the Azure particularities on Simple-OpenAI.

@the-gigi
Copy link
Contributor Author

This PR is not needed due to new URL interceptor.

@the-gigi the-gigi closed this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants