Skip to content

Fix missing json.Unmarshal error check #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix missing json.Unmarshal error check #1045

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e623c7
check error when unmarshalling ExtraBody
sashabaranov Jul 11, 2025
74a7c86
Add error handling for request body unmarshalling
sashabaranov Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion embeddings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,9 @@

// Deserialize JSON to map[string]any
var body map[string]any
_ = json.Unmarshal(jsonData, &body)
if err = json.Unmarshal(jsonData, &body); err != nil {
return
}

Check warning on line 273 in embeddings.go

View check run for this annotation

Codecov / codecov/patch

embeddings.go#L272-L273 

Added lines #L272 - L273 were not covered by tests

req, err := c.newRequest(
ctx,
Expand Down
Loading