Skip to content

[BUGFIX] QueryInterfaceDynamicReturnTypeExtension with TYPO3\CMS\Extb… #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

Kanti
Copy link
Contributor

@Kanti Kanti commented Dec 2, 2022

…ase\Persistence\Generic\Query

In combination with rector We get the error: Uncaught PHPStan\ShouldNotHappenException: Repository class "TYPO3\CMS\Extbase\Persistence\Generic\Query" must implement "TYPO3\CMS\Extbase\Persistence\RepositoryInterface" in /app/vendor/saschaegerer/phpstan-typo3/src/Helpers/Typo3ClassNamingUtilityTrait.php:24

Kanti added 3 commits December 2, 2022 12:01
…ase\Persistence\Generic\Query

In combination with rector We get the error: Uncaught PHPStan\ShouldNotHappenException: Repository class "TYPO3\CMS\Extbase\Persistence\Generic\Query" must implement "TYPO3\CMS\Extbase\Persistence\RepositoryInterface" in
/app/vendor/saschaegerer/phpstan-typo3/src/Helpers/Typo3ClassNamingUtilityTrait.php:24
@Kanti Kanti changed the title [BUGFIX] QueryInterfaceDynamicReturnTypeExtension with TYPO3\CMS\Extb… [WIP][BUGFIX] QueryInterfaceDynamicReturnTypeExtension with TYPO3\CMS\Extb… Dec 2, 2022
@Kanti Kanti changed the title [WIP][BUGFIX] QueryInterfaceDynamicReturnTypeExtension with TYPO3\CMS\Extb… [BUGFIX] QueryInterfaceDynamicReturnTypeExtension with TYPO3\CMS\Extb… Dec 2, 2022
@sascha-egerer
Copy link
Owner

Could you please provide a test code to reproduce the error? I don’t think the current patch will be a good solution as it‘ll just hide an error and does not solve anything.

@sascha-egerer
Copy link
Owner

Hello @Kanti, it looks like this issue happens in combination with rector. As a "should not happen" exception should never happen i don't think its a good idea to catch it. I've prepared i different patch #119 which should also fix this issue. Would be cool If you can give it a try.

@Kanti
Copy link
Contributor Author

Kanti commented Apr 13, 2023

closed in favor of #119

@Kanti Kanti closed this Apr 13, 2023
@Kanti Kanti deleted the patch-1 branch April 13, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants