feat: support timeframe config for binance #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saniales
requested changes
Jan 29, 2025
| @@ -46,6 +46,7 @@ type MarketConfig struct { | |||
| type ExchangeBindingsConfig struct { | |||
| Name string `yaml:"exchange"` // Represents the name of the exchange. | |||
| MarketName string `yaml:"market_name"` // Represents the name of the market as seen from the exchange. | |||
| TimeFrame string `yaml:"time_frame"` | |||
There was a problem hiding this comment.
Can you please add a doc comment for this struct field?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to making a bot with binance I found this error occurred
Digging deeper into souce code I see that we are missing the
Intervalvalue when call Binance API. With this PR, the.bot_config.yamlfile will have extratime_frameconfig like this. For now this ony fixed forGetCandlesfunction. We can add more for functions that use KLineServices to get candles data.