Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dp24 specified reads #361

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from
Open

Dp24 specified reads #361

wants to merge 14 commits into from

Conversation

DLBPointon
Copy link
Contributor

Add support for specified read files.

@DLBPointon DLBPointon changed the base branch from main to dev February 13, 2025 14:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit c1f7264

+| ✅ 126 tests passed       |+
#| ❔  21 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: '1.2.2'
  • pipeline_todos - TODO string in methods_description_template.yml: ## Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release
  • system_exit - System.exit in WorkflowTreeval.groovy: System.exit(1) [line 17]

❔ Tests ignored:

  • files_exist - File is ignored: assets/nf-core-treeval_logo_light.png
  • files_exist - File is ignored: conf/test_full.config
  • files_exist - File is ignored: docs/images/nf-core-treeval_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-treeval_logo_dark.png
  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File does not exist: assets/nf-core-treeval_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-treeval_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-treeval_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/treeval/treeval/.github/workflows/awstest.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2025-03-10 12:59:20

@DLBPointon DLBPointon added the NOT READY YET PR not ready to merge label Feb 13, 2025
@sanger-tol sanger-tol deleted a comment from github-actions bot Feb 13, 2025
@DLBPointon DLBPointon self-assigned this Feb 14, 2025
@DLBPointon DLBPointon added enhancement New feature or request and removed NOT READY YET PR not ready to merge labels Feb 14, 2025
@DLBPointon DLBPointon added this to the Release 1 milestone Feb 14, 2025
@yumisims
Copy link
Contributor

looks fine to me. But I would let Will to approve it as this might change his jira method.

@DLBPointon
Copy link
Contributor Author

looks fine to me. But I would let Will to approve it as this might change his jira method.

That's fair, I imagine it will.

@DLBPointon
Copy link
Contributor Author

Changed pretext module to 0.0.2-yy5-c4 seeing as it contains:

"SANGERTOL_TREEVAL:TREEVAL:HIC_MAPPING:PRETEXT_INGEST_SNDRD:PRETEXT_GRAPH":
    PretextGraph: 0.0.6
    PretextMap:  0.1.9
    bigWigToBedGraph: 447

This will change once the pretextgraph update comes in, next couple of days.

This was referenced Feb 21, 2025
Open
Open
@DLBPointon DLBPointon linked an issue Feb 21, 2025 that may be closed by this pull request
Setup documentation needs updating #365
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yumisims yumisims Awaiting requested review from yumisims

@weaglesBio weaglesBio Awaiting requested review from weaglesBio

At least 1 approving review is required to merge this pull request.

Assignees

@DLBPointon DLBPointon

Labels
enhancement New feature or request
Projects
None yet
Milestone
Release 1
Development

Successfully merging this pull request may close these issues.

Setup documentation needs updating
2 participants
@DLBPointon @yumisims