Pre-release tweaks #22
Open
+1,232
−529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… provided instead of depths
|
…y estimated for an assembly using gzip -l
…st changes; fix missed rename in module config
…eta to allow dynamic resourcing based on length
There was a problem hiding this comment.
Looks really good to me! I'd suggest the README could benefit from more detail on how to run a test and maybe the used nextflow version could be specified.
Also, a couple of really minor comments to the code, if you think it makes sense.
Once the remaining test works should be ready to merge.
| @@ -75,8 +75,8 @@ process { | |||
| } | |||
|
|
|||
| withName: CRAM_FILTER_ALIGN_BWAMEM2_FIXMATE_SORT { | |||
| cpus = 16 | |||
| memory = { 1.GB * (reference.size() < 2e9 ? 80 : Math.ceil(( reference.size() / 1e+9) * 30) * task.attempt) } | |||
| cpus = { 16 * 1 } | |||
There was a problem hiding this comment.
I blame the TreeVal folks... I copied this code verbatim from them!
| include { METATOR_PIPELINE } from '../../../modules/local/metator/pipeline/main' | ||
| include { METATOR_PROCESS_INPUT_BAM } from '../../../modules/local/metator/process_input_bam/main' | ||
| include { BIN3C_MKMAP } from '../../../modules/local/bin3c/mkmap/main.nf' | ||
| include { BIN3C_CLUSTER } from '../../../modules/local/bin3c/cluster/main.nf' |
There was a problem hiding this comment.
Could '.nf' extensions be dropped for consistency in style?
There was a problem hiding this comment.
Nice catch 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).