I194 google analytics #2453
Open
I194 google analytics #2453
+63
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will turn back on the batch email, depositor email, and google analytics settings for the tenants (accounts).
This commit will remove the early return in the user_stat_collection_job since it was too aggressive and will have a condition where it will never run. Also, adding an override to #sorted_users to acocunt for multitenancy in Hyku.
This commit will update the Hyrax revision to bring in the bug fixes for Google Analytics 4 and also update the logic in Hyku's ga4 partial to account for multitenancy more accurately.
Test Results 3 files ±0 3 suites ±0 18m 38s ⏱️ +44s Results for commit 5dc351f. ± Comparison against base commit d9b2bac. This pull request removes 45 and adds 42 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
This commit will remove the early return in the user_stat_collection_job since it was too aggressive and will have a condition where it will never run. Also, adding an override to #sorted_users to acocunt for multitenancy in Hyku.
This commit will update the Hyrax revision to bring in the bug fixes for Google Analytics 4 and also update the logic in Hyku's ga4 partial to account for multitenancy more accurately.
kirkkwang
force-pushed
the
i194-google-analytics
branch
from
a29ebcb to
df8a46e
Compare
This commit will add new environment variables onto the demo deploy to support Google Analytics testing.
…i194-google-analytics
This commit will add the Google environment variables that suppor Google Analytics 4 to the deploy.yaml so we can set it in the github secrets.
This commit will update the Hyrax revision for move GA4 fixes. We will also revert the ga4 partial because that wasn't the root of the problem. The problem was actually because the account_settings did not properly support GA4 settings to allow the ga4 partial to work.
kirkkwang
force-pushed
the
i194-google-analytics
branch
from
dbeb1d0 to
f02783f
Compare
… to analytic settings
This helps to prevent errors caused by nil analytic values
When analytic values are nil the site would crash. This pulls in a fix from hyrax that will rescue and log the errors instead.
Adjusting spec for new options.
This commit will remove the analytics_provider as a setting on the specs to match up with a previous commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧹 Revert account_settings and spec
b585015
This commit will turn back on the batch email, depositor email, and
google analytics settings for the tenants (accounts).
🧹 Remove early return and over add #sorted_users
4d91549
This commit will remove the early return in the user_stat_collection_job
since it was too aggressive and will have a condition where it will
never run. Also, adding an override to #sorted_users to acocunt for
multitenancy in Hyku.
Update Hyrax to bring in bug fixes for GA4
df8a46e
This commit will update the Hyrax revision to bring in the bug fixes for
Google Analytics 4 and also update the logic in Hyku's ga4 partial to
account for multitenancy more accurately.