-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Add UV search params onto other gallery views #2446
Conversation
This commit will remove a method that didn't seem to be working and instead use the #generate_work_url method instead. This way it actually passes the UV search params.
Test Results 3 files ±0 3 suites ±0 17m 48s ⏱️ +13s Results for commit 32bfd02. ± Comparison against base commit 8cd04f0. This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
@kirkkwang Does this also address the Masonry and slideshow views? |
@ShanaLMoore yeah, the screen shots are kinda bad but those are gallery, masonry, and slideshow screen shots |
oops, sorry about that I totally missed it 🙈 |
Issue:
This commit will remove a method that didn't seem to be working and instead use the #generate_work_url method instead. This way it actually passes the UV search params.
Gallery
Masonry
Slideshow