Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add UV search params onto other gallery views #2446

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

kirkkwang
Copy link
Collaborator

@kirkkwang kirkkwang commented Feb 6, 2025

Issue:

This commit will remove a method that didn't seem to be working and instead use the #generate_work_url method instead. This way it actually passes the UV search params.

Gallery

image

Masonry

image

Slideshow

image

This commit will remove a method that didn't seem to be working and
instead use the #generate_work_url method instead.  This way it actually
passes the UV search params.
@kirkkwang kirkkwang added the patch-ver for release notes label Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

Test Results

    3 files  ±0      3 suites  ±0   17m 48s ⏱️ +13s
2 059 tests ±0  2 003 ✅ ±0  56 💤 ±0  0 ❌ ±0 
2 086 runs  ±0  2 028 ✅ ±0  58 💤 ±0  0 ❌ ±0 

Results for commit 32bfd02. ± Comparison against base commit 8cd04f0.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 89f78005-2215-44b9-8599-6160b8f936b2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 3ae396b9-2be2-44b6-806c-4ed1295c1dcf
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 1e249892-45e8-4dd1-a762-7670a1b90b68
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update eb105526-87dd-42db-9ed8-f2f866b2282c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 27cba33d-1d88-464b-9e7b-344ef3259847
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit b96239f3-a1a4-4932-a488-a6491ae31ac6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 0641b82d-6cb1-4a14-891f-d9b9eafffa82
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 49044b54-2c3f-4790-9599-edb847348e2c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 6e6d258b-6fa7-485b-af86-6f6c13f6055f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 87905c0f-40e1-4c41-96c7-80eaa48041a1
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 7b339d17-b31a-447c-8405-db6a1e719fcc
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 3199e0d0-15e2-43af-9097-1d5f2622e8d8
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 8c286069-ce74-4e62-bc83-955f0d5e4458
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update b8786979-622e-4bec-aa00-0bc750a96a55
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 6df67b06-cfe1-43c8-bdfc-b5a2731d2255
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit c866da12-9fe1-4ed4-b24b-8745a684c5d6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read a8881339-0598-4c99-9631-bc1b0c3f287b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update a848ada1-e290-4775-960b-338a6987a6ee
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 832cb713-e695-480d-841b-52bad830f427
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 9c9f2ea0-3913-461e-b524-258dba712b16
…

♻️ This comment has been updated with latest results.

@ShanaLMoore
Copy link
Collaborator

ShanaLMoore commented Feb 6, 2025

@kirkkwang Does this also address the Masonry and slideshow views?

@kirkkwang
Copy link
Collaborator Author

@ShanaLMoore yeah, the screen shots are kinda bad but those are gallery, masonry, and slideshow screen shots

@ShanaLMoore
Copy link
Collaborator

@ShanaLMoore yeah, the screen shots are kinda bad but those are gallery, masonry, and slideshow screen shots

oops, sorry about that I totally missed it 🙈

@kirkkwang kirkkwang merged commit dccf8dc into main Feb 6, 2025
8 of 9 checks passed
@kirkkwang kirkkwang deleted the i199-uv-search-params-on-other-views branch February 6, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants