Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix visual bug with fonts selection label #2435

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

kirkkwang
Copy link
Collaborator

This commit will align the label of the fonts selection label over the dropdown.

Ref:

image

This commit will align the label of the fonts selection label over the
dropdown.

Ref:
- notch8/palni_palci_knapsack#178
@kirkkwang kirkkwang added the patch-ver for release notes label Jan 29, 2025
Copy link

Test Results

    3 files  ±0      3 suites  ±0   18m 9s ⏱️ +3s
2 057 tests ±0  2 001 ✅ ±0  56 💤 ±0  0 ❌ ±0 
2 084 runs  ±0  2 026 ✅ ±0  58 💤 ±0  0 ❌ ±0 

Results for commit 65f70f9. ± Comparison against base commit c388e99.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy cf07345c-8985-418d-a5a8-7e4e6329a6a8
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 92cabd26-2312-4f7a-af9a-a4595b91485c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 5d7f918c-713a-4c0c-9845-9f90ef94f9b4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 6d817093-faa6-4c09-a21b-74be23ff737d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy e9a6e2a8-a23c-485c-8c53-a0c13201704a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit f97f30a9-8ed6-4088-9bfe-b6766c47572d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read a6b895ad-dc5b-436e-90ef-152bf63a2b3c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update bbd04764-883b-481a-af2b-1048c10d3ac8
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 861997ad-716f-4994-9082-5818c13a04a3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 9f22c5f3-740b-482a-bf59-9c0a242e8cad
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 7d7bada9-a8ff-4cce-bee6-67123b02f669
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 85272a32-32a7-4686-9d62-587dd823814d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read f0acd038-0878-41bc-af13-783a09b8eb65
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 17fca75e-ebb2-40f2-b359-e6289793baaf
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 3eb4d752-9175-4dc3-95f7-3d2ea0fd8ead
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit c860a384-6596-408f-a3e9-fca21cdb0f8f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 2fe5b213-c581-49e2-88db-4e793d6fe6d5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update aba9c97a-27c0-40af-9a66-51cbb5f5b50f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 5b65f5f8-4ce2-41db-840f-28bf7bacfb57
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 4aec3ac5-aaf6-4736-8ce8-10f5b5cbf6aa
…

@kirkkwang kirkkwang merged commit e1104a2 into main Jan 29, 2025
8 of 9 checks passed
@kirkkwang kirkkwang deleted the fix-fonts-selection-label-alignment branch January 29, 2025 19:03
kirkkwang added a commit to notch8/palni_palci_knapsack that referenced this pull request Jan 29, 2025
This commit will bring in a pinned version of Hyrax because Hyrax
recently released their Rails 7.2 upgrade.  Also, it will bring in a fix
for the fonts.

Ref:
- samvera/hyku#2435
- samvera/hyku#2436
- #178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants