-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix visual bug with fonts selection label #2435
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will align the label of the fonts selection label over the dropdown. Ref: - notch8/palni_palci_knapsack#178
Test Results 3 files ±0 3 suites ±0 18m 9s ⏱️ +3s Results for commit 65f70f9. ± Comparison against base commit c388e99. This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
|
ShanaLMoore
approved these changes
Jan 29, 2025
kirkkwang
added a commit
to notch8/palni_palci_knapsack
that referenced
this pull request
Jan 29, 2025
This commit will bring in a pinned version of Hyrax because Hyrax recently released their Rails 7.2 upgrade. Also, it will bring in a fix for the fonts. Ref: - samvera/hyku#2435 - samvera/hyku#2436 - #178
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will align the label of the fonts selection label over the dropdown.
Ref: