-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 Fix catalog gallery view #2420
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the Hyrax 5 update the catalog gallery index page had a grid layout of four columns while in default Hyrax has three. Also removed some extra spacing from top row of the items. There was also an extra border that was around the facets that were removed. The description facet on each result has a truncate of 200 characters.
sjproctor
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Test Results 3 files ±0 3 suites ±0 17m 18s ⏱️ -12s Results for commit 49651c5. ± Comparison against base commit 92d95f8. This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the Hyrax 5 update the catalog gallery index page had a grid layout of four columns while in default Hyrax has three. Also removed some extra spacing from top row of the items. There was also an extra border that was around the facets that were removed. The description facet on each result has a truncate of 200 characters.