Skip to content

Commit

Permalink
🧹 Remove Hyrax.config.analytics from the codebase
Browse files Browse the repository at this point in the history
We are now using Hyrax.config.analytics_reporting? instead.  The
analytics_button partial is deprecated and all references removed.

Ref:
- notch8/palni_palci_knapsack#177
  • Loading branch information
kirkkwang committed Jan 30, 2025
1 parent 0f7c56c commit 321c2b6
Show file tree
Hide file tree
Showing 10 changed files with 3 additions and 25 deletions.
5 changes: 0 additions & 5 deletions app/views/hyrax/base/_analytics_button.html.erb

This file was deleted.

2 changes: 1 addition & 1 deletion app/views/hyrax/base/_show_actions.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
class: presenter.display_unfeature_link? ? 'btn btn-secondary' : 'btn btn-secondary collapse' %>
<% end %>
<% end %>
<% if Hyrax.config.analytics? %>
<% if Hyrax.config.analytics_reporting? %>
<% # turbolinks needs to be turned off or the page will use the cache and the %>
<% # analytics graph will not show unless the page is refreshed. %>
<%= link_to t('.analytics'), presenter.stats_path, id: 'stats', class: 'btn btn-secondary', data: { turbolinks: false } %>
Expand Down
3 changes: 0 additions & 3 deletions app/views/hyrax/base/show.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@
<div class="col-sm-3 text-center">
<%= render('download_pdf', presenter: @presenter, file_set_id: @presenter.file_set_presenters.first.id) if @presenter.show_pdf_download_button? %>
<%= render 'citations', presenter: @presenter %>
<!-- OVERRIDE: analytics_button is disabled until future fix -->
<%#= render 'analytics_button', presenter: @presenter %>
<!-- OVERRIDE: remove social_media -->
</div>
<% end %>
<div class="col-sm-9">
Expand Down
2 changes: 1 addition & 1 deletion app/views/hyrax/dashboard/sidebar/_activity.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
</li>
<% end %>

<% if current_ability.can_create_any_work? && Hyrax.config.analytics? %>
<% if current_ability.can_create_any_work? && Hyrax.config.analytics_reporting? %>
<li class="nav-item">
<%= menu.collapsable_section t('hyrax.admin.sidebar.analytics'),
icon_class: "fa fa-pie-chart",
Expand Down
4 changes: 1 addition & 3 deletions app/views/hyrax/oers/show.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<div class="card card-default">
<div class="card-heading">
<%= render 'work_title', presenter: @presenter %>
<%= render 'show_actions', presenter: @presenter %>
<%= render 'show_actions', presenter: @presenter %>
</div>
<div class="card-body">
<div class="row">
Expand All @@ -34,8 +34,6 @@
<div class="col-sm-3 text-center">
<%= render 'representative_media', presenter: @presenter, viewer: false unless @presenter.iiif_viewer? || @presenter.show_pdf_viewer? %>
<%= render 'citations', presenter: @presenter %>
<!-- analytics_button is disabled until future fix -->
<%#= render 'analytics_button', presenter: @presenter %>
</div>
<% end %>
<% if @presenter.viewer? %>
Expand Down
2 changes: 0 additions & 2 deletions app/views/themes/cultural_show/hyrax/base/show.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@
<div class="citations-container">
<%= render 'citations', presenter: @presenter %>
</div>
<!-- analytics_button is disabled until future fix -->
<%#= render 'analytics_button', presenter: @presenter %>
</div>
<div class="col-12 work-show-items">
<%= render 'items', presenter: @presenter %>
Expand Down
4 changes: 0 additions & 4 deletions app/views/themes/cultural_show/hyrax/oers/show.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@
<br/>
<%= render('download_pdf', presenter: @presenter, file_set_id: @presenter.file_set_presenters.first.id) if @presenter.show_pdf_download_button? %>
<%= render 'citations', presenter: @presenter %>
<!-- analytics_button is disabled until future fix -->
<%#= render 'analytics_button', presenter: @presenter %>
<br/>
</div>
<% end %>
Expand All @@ -54,8 +52,6 @@
<br/>
<%= render('download_pdf', presenter: @presenter, file_set_id: @presenter.file_set_presenters.first.id) if @presenter.show_pdf_download_button? %>
<%= render 'citations', presenter: @presenter %>
<!-- analytics_button is disabled until future fix -->
<%#= render 'analytics_button', presenter: @presenter %>
<br/>
</div>
<% end %>
Expand Down
2 changes: 0 additions & 2 deletions app/views/themes/image_show/hyrax/base/show.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@
<div class="col-sm-3 citations-social text-right">
<%= render('download_pdf', presenter: @presenter, file_set_id: @presenter.file_set_presenters.first.id) if @presenter.show_pdf_download_button? %>
<%= render 'citations', presenter: @presenter %>
<!-- analytics_button is disabled until future fix -->
<%#= render 'analytics_button', presenter: @presenter %>
</div>
<div class="col-sm-12">
<%= render 'relationships', presenter: @presenter %>
Expand Down
2 changes: 0 additions & 2 deletions app/views/themes/scholarly_show/hyrax/base/show.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,6 @@
<div class="col-sm-3 text-center">
<%= render('download_pdf', presenter: @presenter, file_set_id: @presenter.file_set_presenters.first.id) if @presenter.show_pdf_download_button? %>
<%= render 'citations', presenter: @presenter %>
<!-- analytics_button is disabled until future fix -->
<%#= render 'analytics_button', presenter: @presenter %>
</div>
</div>
<div class="row">
Expand Down
2 changes: 0 additions & 2 deletions app/views/themes/scholarly_show/hyrax/oers/show.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@
<div class="col-sm-6">
<%= render('download_pdf', presenter: @presenter, file_set_id: @presenter.file_set_presenters.first.id) if @presenter.show_pdf_download_button? %>
<%= render 'citations', presenter: @presenter %>
<!-- analytics_button is disabled until future fix -->
<%#= render 'analytics_button', presenter: @presenter %>
</div>
<div class="col-sm-12">
<%= render 'relationships', presenter: @presenter %>
Expand Down

0 comments on commit 321c2b6

Please sign in to comment.