Skip to content

Commit

Permalink
5.4.0-bug-fixes (#865)
Browse files Browse the repository at this point in the history
* restore the ability to load the "/importers" page.

there was an extra "x" in the app/views/bulkrax/importers/_oai_fields.html.erb file. it threw a syntax error when trying to create a new
importer.

* restore our ability to properly look up works by their `work_identifier`

- ref: #866
- ref:#867
  • Loading branch information
alishaevn authored Oct 4, 2023
1 parent 9ea4de6 commit 0e68a5e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 5 additions & 1 deletion app/factories/bulkrax/object_factory.rb
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,11 @@ def find_or_create
end

def search_by_identifier
work_index = ::ActiveFedora.index_field_mapper.solr_name(work_identifier, :facetable)
# TODO(alishaevn): return the proper `work_index` value below
# ref: https://github.com/samvera-labs/bulkrax/issues/866
# ref:https://github.com/samvera-labs/bulkrax/issues/867
# work_index = ::ActiveFedora.index_field_mapper.solr_name(work_identifier, :facetable)
work_index = work_identifier
query = { work_index =>
source_identifier_value }
# Query can return partial matches (something6 matches both something6 and something68)
Expand Down
2 changes: 1 addition & 1 deletion app/views/bulkrax/importers/_oai_fields.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
['Public', 'open'],
['Private', 'restricted'],
['Institution', 'authenticated']
],x
],
selected: importer.parser_fields['visibility'] || 'open',
input_html: { class: 'form-control' }
%>
Expand Down

0 comments on commit 0e68a5e

Please sign in to comment.