Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix connection interrupt/disconnect issue #998

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix connection interrupt/disconnect issue #998

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7a4a0e
prevent network interruption crash
Joren-vanGoethem Aug 28, 2021
b95468e
Merge pull request #1 from Algo-Trading-IBKR/prevent-crash-after-netw…
Joren-vanGoethem Aug 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions binance/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6534,6 +6534,12 @@ async def _request(self, method, uri: str, signed: bool, force_params: bool = Fa

kwargs = self._get_request_kwargs(method, signed, force_params, **kwargs)

# checks if there is still a connection to binance before sending request and crashing
while True:
test = getattr(self.session, method)(uri, **kwargs)
if test.status_code == 200:
break

async with getattr(self.session, method)(uri, **kwargs) as response:
self.response = response
return await self._handle_response(response)
Expand Down