Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added get_latest_price_by_symbol(self,symbol) -> float #1112

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added get_latest_price_by_symbol(self,symbol) -> float #1112

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d80c03
Added get_latest_price(symbol) function
arnabm14 Dec 27, 2021
c47f8ce
Changed Heading to Latest price by Symbol
arnabm14 Feb 23, 2022
8b6f95a
Updated the function description and changed the for loop to single s…
arnabm14 Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions binance/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,28 @@ def get_symbol_info(self, symbol) -> Optional[Dict]:
return item

return None

def get_latest_price_by_symbol(self,symbol) -> float:
"""Latest price for One specific symbols.

Reference Document : https://binance-docs.github.io/apidocs/spot/en/#symbol-price-ticker

:returns: Latest Price of a coin

.. code-block:: python

input : BNBUSDT
output : 600.2

:raises: BinanceRequestException, BinanceAPIException

"""
val=0.0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is defined here for now reason

list_price= [x['price'] for x in self.get_all_tickers() if x['symbol']==symbol]

val = list_price[-1]['price']
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will crash if symbol is not found in the list of tickers


return float(val)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Float can cause precision issues and may not be what is wanted by other users. Passing in a formatter to allow for float or Decimal may be a better option here.

# General Endpoints

def ping(self) -> Dict:
Expand Down