Add exposure time and idle time services #38
Merged
+368
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- service architecture works now
- used resolution argument instead of config - fix response error code logic
|
Did you consider using ros parameters? In ROS this would have required dynamic reconfigure, but in ROS2 this is no longer needed as this is part of the base paramter functionality. |
dave992
requested changes
Oct 9, 2024
micro_epsilon_scancontrol_driver/include/micro_epsilon_scancontrol_driver/driver.h
Outdated
Show resolved
Hide resolved
micro_epsilon_scancontrol_driver/include/micro_epsilon_scancontrol_driver/driver.h
Outdated
Show resolved
Hide resolved
This might be worth looking into. I'll check it out when I get time, and move ahead with services for now. |
nikhil-sethi
requested review from
dave992
and removed request for
aashish-tud
nikhil-sethi
added
enhancement
erichlf
reviewed
Oct 16, 2024
micro_epsilon_scancontrol_driver/include/micro_epsilon_scancontrol_driver/driver.h
Outdated
Show resolved
Hide resolved
micro_epsilon_scancontrol_driver/include/micro_epsilon_scancontrol_driver/driver.h
Outdated
Show resolved
Hide resolved
erichlf
reviewed
Oct 16, 2024
micro_epsilon_scancontrol_driver/include/micro_epsilon_scancontrol_driver/driver.h
Outdated
Show resolved
Hide resolved
erichlf
reviewed
Oct 16, 2024
erichlf
reviewed
Oct 16, 2024
micro_epsilon_scancontrol_driver/include/micro_epsilon_scancontrol_driver/driver.h
Outdated
Show resolved
Hide resolved
erichlf
approved these changes
Oct 16, 2024
dave992
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of MR:
Add exposure time + idle time services
Motivation and Context
Exposure time and idle time collectively decide the profile frequency which is a sensitive parameter for detecting defects. We need a service to control this param.
Changes
Type of changes
Checklist
Docs: https://samxl.atlassian.net/wiki/spaces/NXTG3/pages/553091077/Encoding+Decoding+in+scanControl+SDK