Update npp.sls #2068
Merged
Update npp.sls #2068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
version 8.5.4 has been reported security vulnerabilities, update latest version.
twangboy
requested changes
Jan 18, 2024
Conflicted version 32bit vs 64bit caused test failed. Removed x64bit version.
twangboy
approved these changes
Jan 19, 2024
twangboy
requested changes
Jan 19, 2024
Removes version 8.5.5 caused test failed
twangboy
approved these changes
Jan 22, 2024
|
Thanks for getting those changes in! |
|
@twangboy is this correct to entirely remove that version? I would have thought of creating a 'with CVE' category and removing its ability to be installed but leaving in the section to be uninstalled. Much like you guys do for the windows salt-minion would be better? No? |
|
That's basically what that list at the bottom is for. Since you're adding a new version, it is not required that you add the CVE version of npp to the bottom list. If this was a version that used to be managed using a salt package definition, then you would need to move it to the bottom list. That bottom list is basically remove only as it does not define an installation parameter. Since you were adding a new version, it was up to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version 8.5.4 has been reported security vulnerabilities, update latest version.