Do manual trait casting #922
Open
+391
−285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #922 will improve performances by 4.2%Comparing Summary
Benchmarks breakdown
|
Veykril
force-pushed
the
veykril/push-tsxunswownmm
branch
4 times, most recently
from
2073e08 to
28acf8c
Compare
|
Benchmarks look fairly noisy again to me |
|
Not sure, 5% is a bit more than usual. |
|
Well the increase seems to stem from ingredient fetching which means its likely the |
Veykril
force-pushed
the
veykril/push-tsxunswownmm
branch
2 times, most recently
from
0b13ad9 to
e50ed3a
Compare
|
Okay the regression came from a dumb mistake |
Veykril
changed the title
Veykril
force-pushed
the
veykril/push-tsxunswownmm
branch
from
e50ed3a to
523d4c8
Compare
|
Some context for reviewing aid, there are couple of noisy changes (that I could've split out into separate commits, sorry):
|
Veykril
commented
Jul 30, 2025
| } | ||
| } | ||
|
|
||
| /// Upcast to a `dyn Database`. | ||
| /// | ||
| /// Only required because upcasts not yet stabilized (*grr*). | ||
| /// Only required because upcasting does not work for unsized generic parameters. |
There was a problem hiding this comment.
I am quite annoyed by this but that's a limitation of Rust, a &T of T: ?Sized + SomeTrait cannot be coerced to a &dyn SomeTrait (or a supertrait) due to T possibly being an unrelated unsized type like str
Veykril
force-pushed
the
veykril/push-tsxunswownmm
branch
from
f553491 to
70bdaef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes occurences of
dyn Databaseinternally where only the zalsas are needed for (hopefully) a perf increase.Lastly it renames downcasting to upcasting, because thats what we are doing,
dyn Database--downcast->Concrete--upcast-->dyn CustomDatabaseTrait