W-18921869 Warning for flexcard with Navigate URL #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -183,5 +183,6 @@ | |||
| "missingInfo": "Info is missing", | |||
| "errorCheckingGlobalAutoNumber": "We couldn’t check whether the Global Auto Number setting is enabled: %s. Try again later.", | |||
| "errorMigrationMessage": "Error migrating object: %s", | |||
| "nameMappingUndefined": "Name Mapping is undefined" | |||
| "nameMappingUndefined": "Name Mapping is undefined", | |||
| "webPageOmniScriptNavigationDetected": "Web page omniscript navigate url needs manual intervention" | |||
There was a problem hiding this comment.
We also need to add the callToAction for manual intervention tasks, can you check other manual ones and add one for this one as well
There was a problem hiding this comment.
The call to action should capture what should be change in it
| flexCardAssessmentInfo.warnings.push( | ||
| this.messages.getMessage('webPageOmniScriptNavigationDetected', [targetName]) | ||
| ); | ||
| flexCardAssessmentInfo.migrationStatus = 'Need Manual Intervention'; |
There was a problem hiding this comment.
This is assessment status only. The migration status will show Completed.
There was a problem hiding this comment.
Migration status completed with warning? Ideally we should be skipping the items which aren't corrected in assessment
|
Please don'r merge the changes until we get feedback from Product |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Flexcards can contain the navigate action which can have Omniscript URL. But since the migration happens in sandbox org and later the customer deploys the metadata to some other org, so we have decided to go ahead with displaying warning to notify the customer that manual intervention is required for them to handle the url.