This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Breaking up Integration tests #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanlemon
reviewed
Nov 21, 2017
| */ | ||
| @Override | ||
| public void open(Map topologyConfig, TopologyContext topologyContext, SpoutOutputCollector spoutOutputCollector) { | ||
| if (isOpen) { | ||
| logger.warn("This spout has already been opened, cowardly refusing to open it again!"); | ||
| return; | ||
| throw new IllegalStateException("This spout has already been opened."); |
There was a problem hiding this comment.
I suspect this is ok, but this is a noteworthy change.
|
@stanlemon This should be ready for review. I think you already pointed out the only real logic change. The rest is just moving tests around. Looks like no discernible increase in test run time either => 04:28 min |
Crim
changed the title
added 8 commits
November 22, 2017 22:06
…t, SidelineSpoutTest, KafkaConsumerTest
stanlemon
force-pushed
the
sp/BreakUpIntegrationTests
branch
from
f1f02f0 to
13c2072
Compare
stanlemon
approved these changes
Nov 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start to breakup the integration test DynamicSpoutTest into:
DynamicSpoutTest - Covering DynamicSpout using a stand-in MockConsumer (and no sidelining logic)
SidelineSpoutTest - Covering just the Sidelining functionality, makes use of KafkaConsumer to help validate various scenarios.
KafkaConsumerTest - Integration test covering the KafkaConsumer within DynamicSpout, covers no sidelining logic.
This moves us towards being able to do #19