-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a meaningful PR body for parent/child commands #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
============================================
+ Coverage 72.81% 73.40% +0.59%
- Complexity 212 217 +5
============================================
Files 15 16 +1
Lines 765 786 +21
Branches 106 107 +1
============================================
+ Hits 557 577 +20
Misses 187 187
- Partials 21 22 +1
|
This should prep for more customizable pull request info and take some responsibilities out of DockerfileGitHubUtil
afalko
previously approved these changes
Jun 3, 2020
@afalko do you mind poking this one again? The update from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add a body like the following to
parent
andchild
commands instead off9ed6ea5-6e74-4338-a629-50c5c6807a6b
:After this, we just need to do this for the
all
subcommand in order for it to also handle #149